pollux.dependency.onClick - Code Metrics - Inspection of "use GateKeeper" - pryley/pollux - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( a578dd...775faa )

by Paul

created 2017-05-12 06:09 UTC

pollux.dependency.onClick A

↳ Parent: +/main.js

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
nc	4
nop	1
dl	0
loc	11
rs	9.2
c	0
b	0
f	0

/** global: wp, pollux, CodeMirror */

pollux.dependency = {};
pollux.editors = {};
pollux.featured = {};
pollux.metabox = {};
pollux.tabs = {};

/**
 * @return bool
 */
pollux.classListAction = function( bool )
{
	return bool ? 'add' : 'remove';
};

/**
 * @return void
 */
pollux.dependency.activate = function( el )
{
	pollux.dependency.updateButtonText( el, pollux.vars.l10n.pluginActivatingLabel );
	return pollux.dependency.ajax( 'pollux/dependency/activate', el );
};

/**
 * @return void
 */
pollux.dependency.ajax = function( action, el )
{
	var args = pollux.dependency.getAjaxOptions( el );
	var options = {
		success: args.success,
		error: args.error,
	};
	delete args.success;
	delete args.error;
	options.data = args;
	wp.ajax.send( action, options );
};

/**
 * @return object
 */
pollux.dependency.getAjaxOptions = function( el )
{
	return {
		_ajax_nonce: wp.updates.ajaxNonce,
		error: pollux.dependency.onError.bind( el ),
		plugin: el.getAttribute( 'data-plugin' ),
		slug: el.getAttribute( 'data-slug' ),
		success: pollux.dependency.onSuccess.bind( el ),
	};
};

/**
 * @return void
 */
pollux.dependency.init = function()
{
	pollux.dependency.buttons = document.querySelectorAll( '.pollux-notice a.button' );
	[].forEach.call( pollux.dependency.buttons, function( button ) {
		button.addEventListener( 'click', pollux.dependency.onClick );
	});
};

/**
 * @return void
 */
pollux.dependency.install = function( el, args )
{
	pollux.dependency.updateButtonText( el, wp.updates.l10n.pluginInstallingLabel );
	return wp.updates.ajax( 'install-plugin', args );
};

/**
 * @return void
 */
pollux.dependency.onClick = function( ev )
{
	var action = this.href.match(/action=([^&]+)/);
	if( action === null )return;
if (a > 0)
    b = 42;
	action = action[1].split('-')[0];
	if( !pollux.dependency[action] )return;
if (a > 0)
    b = 42;
	this.blur();
	ev.preventDefault();
	if( this.classList.contains( 'updating-message' ))return;
if (a > 0)
    b = 42;
	pollux.dependency[action]( this, pollux.dependency.getAjaxOptions( this ));
};

/**
 * @return void
 */
pollux.dependency.onError = function( response )

{
	window.location = this.href;
};

/**
 * @return void
 */
pollux.dependency.onSuccess = function( response )
{
	var el = this;
	if( response.update ) {
		return pollux.dependency.ajax( 'pollux/dependency/updated', el );
	}
	pollux.dependency.setUpdatedMessage( el );
	if( response.install ) {
		el.innerHTML = wp.updates.l10n.pluginInstalledLabel.replace( '%s', response.pluginName );
	}
	if( response.updated ) {
		el.innerHTML = wp.updates.l10n.updatedLabel.replace( '%s', response.pluginName );
	}
	if( response.activateUrl ) {
		setTimeout( function() {
			pollux.dependency.setActivateButton( el, response );
		}, 1000 );
	}
	if( response.activate ) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
		el.innerHTML = pollux.vars.l10n.pluginActivatedLabel.replace( '%s', response.pluginName );
		setTimeout( function() {
			var notice = el.closest( '.pollux-notice' );
			if( pollux.dependency.buttons.length < 2 ) {
				pollux.editors.all.forEach( function( editor, index ) {
					pollux.editors.enable( index );
				});
				notice.parentNode.removeChild( notice );
			}
			else {
				var plugin = notice.querySelector( '.plugin-' + response.slug );
				plugin.parentNode.removeChild( plugin );
				el.parentNode.removeChild( el );
			}
		}, 1000 );

	}
};

/**
 * @return void
 */
pollux.dependency.setActivateButton = function( el, response )
{
	el.classList.remove( 'updated-message' );
	el.classList.remove( 'button-disabled' );
	el.classList.add( 'button-primary' );
	el.href = response.activateUrl;
	el.innerHTML = wp.updates.l10n.activatePluginLabel.replace( '%s', response.pluginName );
};

/**
 * @return void
 */
pollux.dependency.setUpdatedMessage = function( el )
{
	el.classList.remove( 'updating-message' );
	el.classList.add( 'updated-message' );
	el.classList.add( 'button-disabled' );
};

/**
 * @return void
 */
pollux.dependency.updateButtonText = function( el, text )
{
	var label = text.replace( '%s', el.getAttribute( 'data-name' ));
	if( el.innerHTML !== label ) {
		el.innerHTML = label;
		el.classList.add( 'updating-message' );
	}
};

/**
 * @return void
 */
pollux.dependency.upgrade = function( el, args )
{
	pollux.dependency.updateButtonText( el, wp.updates.l10n.updatingLabel );
	return wp.updates.ajax( 'update-plugin', args );
};

/**
 * @return void
 */
pollux.editors.disable = function( index )
{
	pollux.editors.all[index].setOption( 'theme', 'disabled' );
	pollux.editors.all[index].setOption( 'readOnly', 'nocursor' );
	pollux.editors.all[index].getTextArea().readOnly = true;
	pollux.editors.all[index].refresh();
};

/**
 * @return void
 */
pollux.editors.enable = function( index )
{
	pollux.editors.all[index].setOption( 'theme', 'pollux' );
	pollux.editors.all[index].setOption( 'readOnly', false );
	pollux.editors.all[index].getTextArea().readOnly = false;
	pollux.editors.all[index].refresh();
};

/**
 * @return void
 */
pollux.editors.init = function()
{
	pollux.editors.all = [];
	[].forEach.call( document.querySelectorAll( '.pollux-code' ), function( editor, index ) {
		pollux.editors.all[index] = CodeMirror.fromTextArea( editor, {
			gutters: ['CodeMirror-lint-markers'],
			highlightSelectionMatches: { wordsOnly: true },
			lineNumbers: true,
			lint: true,
			mode: 'text/yaml',
			showInvisibles: true,
			showTrailingSpace: true,
			styleActiveLine: true,
			tabSize: 2,
			theme: 'pollux',
			viewportMargin: Infinity,
		});
		pollux.editors.all[index].setOption( 'extraKeys', {
			Tab: function( cm ) {
				var spaces = Array( cm.getOption( 'indentUnit' ) + 1 ).join( ' ' );
				cm.replaceSelection( spaces );
			},
		});
		pollux.editors.all[index].display.wrapper.setAttribute( 'data-disabled', editor.getAttribute( 'data-disabled' ));
		if( editor.readOnly ) {
			pollux.editors.disable( index );
		}
	});
};

/**
 * @return void
 */
pollux.featured.init = function()
{
	jQuery( '#postimagediv' )
	.on( 'click', '#pollux-set-featured', function( ev ) {
		ev.preventDefault();
		wp.media.view.settings.post.featuredImageId = Math.round( jQuery( '#featured' ).val() );
		pollux.featured.frame = wp.media.featuredImage.frame;
		pollux.featured.frame().open();
	})
	.on( 'click', '#pollux-remove-featured', function( ev ) {
		ev.preventDefault();
		pollux.featured.set(-1);
	});
};

/**
 * @return void
 */
pollux.featured.select = function()
{
	if( !wp.media.view.settings.post.featuredImageId )return;
	var selection = this.get( 'selection' ).single();
	pollux.featured.set( selection ? selection.id : -1 );
};

/**
 * @return void
 */
pollux.featured.set = function( id )
{
	wp.media.view.settings.post.featuredImageId = Math.round( id );
	wp.media.post( 'pollux/archives/featured/html', {
		_wpnonce: document.querySelector( '#_wpnonce' ).value,
		post_type: document.querySelector( '#archive-type' ).value,
		thumbnail_id: id,
	}).done( function( html ) {
		document.querySelector( '#postimagediv > .inside' ).innerHTML = html;
	});
};

/**
 * @return bool
 */
pollux.metabox.hasValue = function( el )
{
	if( el.type === 'checkbox' ) {
		return el.checked === true;
	}
	return el.value !== '';
};

/**
 * @return void
 */
pollux.metabox.init = function()
{
	var depends = document.querySelectorAll( '.rwmb-input [data-depends]' );
	[].forEach.call( depends, function( el ) {
		var dependency = pollux.metabox.setVisibility( el );
		var event = dependency.type === 'checkbox' ? 'change' : 'keyup';
		dependency.addEventListener( event, function() {
			pollux.metabox.setVisibility( el );
		});
	});
};

/**
 * @return element
 */
pollux.metabox.setVisibility = function( el )
{
	var dependency = document.getElementById( el.getAttribute( 'data-depends' ));
	var action = pollux.classListAction( !pollux.metabox.hasValue( dependency ));
	el.closest( '.rwmb-field' ).classList[action]( 'hidden' );
	return dependency;
};

/**
 * @return void
 */
pollux.tabs.init = function()
{
	pollux.tabs.active = document.querySelector( '#pollux-active-tab' );
	pollux.tabs.referrer = document.querySelector( 'input[name="_wp_http_referer"]' );
	pollux.tabs.tabs = document.querySelectorAll( '.pollux-tabs a' );
	pollux.tabs.views = document.querySelectorAll( '.pollux-config .form-table' );

	[].forEach.call( pollux.tabs.tabs, function( tab, index ) {
		var active = location.hash ? tab.getAttribute( 'href' ).slice(1) === location.hash.slice(2) : index === 0;
		if( active ) {
			pollux.tabs.setTab( tab );
		}
		tab.addEventListener( 'click', pollux.tabs.onClick );
		tab.addEventListener( 'touchend', pollux.tabs.onClick );
	});
};

/**
 * @return void
 */
pollux.tabs.onClick = function( ev )
{
	ev.preventDefault();
	this.blur();
	pollux.tabs.setTab( this );
	location.hash = '!' + this.getAttribute( 'href' ).slice(1);
};

/**
 * @return void
 */
pollux.tabs.setReferrer = function( index )
{
	var referrerUrl = pollux.tabs.referrer.value.split('#')[0] + '#!' + pollux.tabs.views[index].id;
	pollux.tabs.referrer.value = referrerUrl;
};

/**
 * @return void
 */
pollux.tabs.setTab = function( el )
{
	[].forEach.call( pollux.tabs.tabs, function( tab, index ) {
		var action = pollux.classListAction( tab === el );
		if( action === 'add' ) {
			pollux.tabs.active.value = pollux.tabs.views[index].id;
			pollux.tabs.setReferrer( index );
			pollux.tabs.setView( index );
		}
		tab.classList[action]( 'nav-tab-active' );
	});
};

/**
 * @return void
 */
pollux.tabs.setView = function( idx )
{
	[].forEach.call( pollux.tabs.views, function( view, index ) {
		var action = pollux.classListAction( index !== idx );
		view.classList[action]( 'ui-tabs-hide' );
	});
};

jQuery(function() {
	for( var key in pollux ) {
var someObject;
for (var key in someObject) {
    if ( ! someObject.hasOwnProperty(key)) {
        continue; // Skip keys from the prototype.
    }

    doSomethingWith(key);
}
		if( !pollux[key].hasOwnProperty( 'init' ))continue;
if (a > 0)
    b = 42;
		pollux[key].init();
	}
});


1			/** global: wp, pollux, CodeMirror */
2
3			pollux.dependency = {};
4			pollux.editors = {};
5			pollux.featured = {};
6			pollux.metabox = {};
7			pollux.tabs = {};
8
9			/**
10			* @return bool
11			*/
12			pollux.classListAction = function( bool )
13			{
14			return bool ? 'add' : 'remove';
15			};
16
17			/**
18			* @return void
19			*/
20			pollux.dependency.activate = function( el )
21			{
22			pollux.dependency.updateButtonText( el, pollux.vars.l10n.pluginActivatingLabel );
23			return pollux.dependency.ajax( 'pollux/dependency/activate', el );
24			};
25
26			/**
27			* @return void
28			*/
29			pollux.dependency.ajax = function( action, el )
30			{
31			var args = pollux.dependency.getAjaxOptions( el );
32			var options = {
33			success: args.success,
34			error: args.error,
35			};
36			delete args.success;
37			delete args.error;
38			options.data = args;
39			wp.ajax.send( action, options );
40			};
41
42			/**
43			* @return object
44			*/
45			pollux.dependency.getAjaxOptions = function( el )
46			{
47			return {
48			_ajax_nonce: wp.updates.ajaxNonce,
49			error: pollux.dependency.onError.bind( el ),
50			plugin: el.getAttribute( 'data-plugin' ),
51			slug: el.getAttribute( 'data-slug' ),
52			success: pollux.dependency.onSuccess.bind( el ),
53			};
54			};
55
56			/**
57			* @return void
58			*/
59			pollux.dependency.init = function()
60			{
61			pollux.dependency.buttons = document.querySelectorAll( '.pollux-notice a.button' );
62			[].forEach.call( pollux.dependency.buttons, function( button ) {
63			button.addEventListener( 'click', pollux.dependency.onClick );
64			});
65			};
66
67			/**
68			* @return void
69			*/
70			pollux.dependency.install = function( el, args )
71			{
72			pollux.dependency.updateButtonText( el, wp.updates.l10n.pluginInstallingLabel );
73			return wp.updates.ajax( 'install-plugin', args );
74			};
75
76			/**
77			* @return void
78			*/
79			pollux.dependency.onClick = function( ev )
80			{
81			var action = this.href.match(/action=([^&]+)/);
82			if( action === null )return;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
83			action = action[1].split('-')[0];
84			if( !pollux.dependency[action] )return;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
85			this.blur();
86			ev.preventDefault();
87			if( this.classList.contains( 'updating-message' ))return;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
88			pollux.dependency[action]( this, pollux.dependency.getAjaxOptions( this ));
89			};
90
91			/**
92			* @return void
93			*/
94			pollux.dependency.onError = function( response )
			0 ignored issues – show Unused Code introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report The parameter `response` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
95			{
96			window.location = this.href;
97			};
98
99			/**
100			* @return void
101			*/
102			pollux.dependency.onSuccess = function( response )
103			{
104			var el = this;
105			if( response.update ) {
106			return pollux.dependency.ajax( 'pollux/dependency/updated', el );
107			}
108			pollux.dependency.setUpdatedMessage( el );
109			if( response.install ) {
110			el.innerHTML = wp.updates.l10n.pluginInstalledLabel.replace( '%s', response.pluginName );
111			}
112			if( response.updated ) {
113			el.innerHTML = wp.updates.l10n.updatedLabel.replace( '%s', response.pluginName );
114			}
115			if( response.activateUrl ) {
116			setTimeout( function() {
117			pollux.dependency.setActivateButton( el, response );
118			}, 1000 );
119			}
120			if( response.activate ) {
			0 ignored issues – show Complexity Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report There is no return statement if `response.activate` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
121			el.innerHTML = pollux.vars.l10n.pluginActivatedLabel.replace( '%s', response.pluginName );
122			setTimeout( function() {
123			var notice = el.closest( '.pollux-notice' );
124			if( pollux.dependency.buttons.length < 2 ) {
125			pollux.editors.all.forEach( function( editor, index ) {
126			pollux.editors.enable( index );
127			});
128			notice.parentNode.removeChild( notice );
129			}
130			else {
131			var plugin = notice.querySelector( '.plugin-' + response.slug );
132			plugin.parentNode.removeChild( plugin );
133			el.parentNode.removeChild( el );
134			}
135			}, 1000 );
			0 ignored issues – show Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
136			}
137			};
138
139			/**
140			* @return void
141			*/
142			pollux.dependency.setActivateButton = function( el, response )
143			{
144			el.classList.remove( 'updated-message' );
145			el.classList.remove( 'button-disabled' );
146			el.classList.add( 'button-primary' );
147			el.href = response.activateUrl;
148			el.innerHTML = wp.updates.l10n.activatePluginLabel.replace( '%s', response.pluginName );
149			};
150
151			/**
152			* @return void
153			*/
154			pollux.dependency.setUpdatedMessage = function( el )
155			{
156			el.classList.remove( 'updating-message' );
157			el.classList.add( 'updated-message' );
158			el.classList.add( 'button-disabled' );
159			};
160
161			/**
162			* @return void
163			*/
164			pollux.dependency.updateButtonText = function( el, text )
165			{
166			var label = text.replace( '%s', el.getAttribute( 'data-name' ));
167			if( el.innerHTML !== label ) {
168			el.innerHTML = label;
169			el.classList.add( 'updating-message' );
170			}
171			};
172
173			/**
174			* @return void
175			*/
176			pollux.dependency.upgrade = function( el, args )
177			{
178			pollux.dependency.updateButtonText( el, wp.updates.l10n.updatingLabel );
179			return wp.updates.ajax( 'update-plugin', args );
180			};
181
182			/**
183			* @return void
184			*/
185			pollux.editors.disable = function( index )
186			{
187			pollux.editors.all[index].setOption( 'theme', 'disabled' );
188			pollux.editors.all[index].setOption( 'readOnly', 'nocursor' );
189			pollux.editors.all[index].getTextArea().readOnly = true;
190			pollux.editors.all[index].refresh();
191			};
192
193			/**
194			* @return void
195			*/
196			pollux.editors.enable = function( index )
197			{
198			pollux.editors.all[index].setOption( 'theme', 'pollux' );
199			pollux.editors.all[index].setOption( 'readOnly', false );
200			pollux.editors.all[index].getTextArea().readOnly = false;
201			pollux.editors.all[index].refresh();
202			};
203
204			/**
205			* @return void
206			*/
207			pollux.editors.init = function()
208			{
209			pollux.editors.all = [];
210			[].forEach.call( document.querySelectorAll( '.pollux-code' ), function( editor, index ) {
211			pollux.editors.all[index] = CodeMirror.fromTextArea( editor, {
212			gutters: ['CodeMirror-lint-markers'],
213			highlightSelectionMatches: { wordsOnly: true },
214			lineNumbers: true,
215			lint: true,
216			mode: 'text/yaml',
217			showInvisibles: true,
218			showTrailingSpace: true,
219			styleActiveLine: true,
220			tabSize: 2,
221			theme: 'pollux',
222			viewportMargin: Infinity,
223			});
224			pollux.editors.all[index].setOption( 'extraKeys', {
225			Tab: function( cm ) {
226			var spaces = Array( cm.getOption( 'indentUnit' ) + 1 ).join( ' ' );
227			cm.replaceSelection( spaces );
228			},
229			});
230			pollux.editors.all[index].display.wrapper.setAttribute( 'data-disabled', editor.getAttribute( 'data-disabled' ));
231			if( editor.readOnly ) {
232			pollux.editors.disable( index );
233			}
234			});
235			};
236
237			/**
238			* @return void
239			*/
240			pollux.featured.init = function()
241			{
242			jQuery( '#postimagediv' )
243			.on( 'click', '#pollux-set-featured', function( ev ) {
244			ev.preventDefault();
245			wp.media.view.settings.post.featuredImageId = Math.round( jQuery( '#featured' ).val() );
246			pollux.featured.frame = wp.media.featuredImage.frame;
247			pollux.featured.frame().open();
248			})
249			.on( 'click', '#pollux-remove-featured', function( ev ) {
250			ev.preventDefault();
251			pollux.featured.set(-1);
252			});
253			};
254
255			/**
256			* @return void
257			*/
258			pollux.featured.select = function()
259			{
260			if( !wp.media.view.settings.post.featuredImageId )return;
261			var selection = this.get( 'selection' ).single();
262			pollux.featured.set( selection ? selection.id : -1 );
263			};
264
265			/**
266			* @return void
267			*/
268			pollux.featured.set = function( id )
269			{
270			wp.media.view.settings.post.featuredImageId = Math.round( id );
271			wp.media.post( 'pollux/archives/featured/html', {
272			_wpnonce: document.querySelector( '#_wpnonce' ).value,
273			post_type: document.querySelector( '#archive-type' ).value,
274			thumbnail_id: id,
275			}).done( function( html ) {
276			document.querySelector( '#postimagediv > .inside' ).innerHTML = html;
277			});
278			};
279
280			/**
281			* @return bool
282			*/
283			pollux.metabox.hasValue = function( el )
284			{
285			if( el.type === 'checkbox' ) {
286			return el.checked === true;
287			}
288			return el.value !== '';
289			};
290
291			/**
292			* @return void
293			*/
294			pollux.metabox.init = function()
295			{
296			var depends = document.querySelectorAll( '.rwmb-input [data-depends]' );
297			[].forEach.call( depends, function( el ) {
298			var dependency = pollux.metabox.setVisibility( el );
299			var event = dependency.type === 'checkbox' ? 'change' : 'keyup';
300			dependency.addEventListener( event, function() {
301			pollux.metabox.setVisibility( el );
302			});
303			});
304			};
305
306			/**
307			* @return element
308			*/
309			pollux.metabox.setVisibility = function( el )
310			{
311			var dependency = document.getElementById( el.getAttribute( 'data-depends' ));
312			var action = pollux.classListAction( !pollux.metabox.hasValue( dependency ));
313			el.closest( '.rwmb-field' ).classList[action]( 'hidden' );
314			return dependency;
315			};
316
317			/**
318			* @return void
319			*/
320			pollux.tabs.init = function()
321			{
322			pollux.tabs.active = document.querySelector( '#pollux-active-tab' );
323			pollux.tabs.referrer = document.querySelector( 'input[name="_wp_http_referer"]' );
324			pollux.tabs.tabs = document.querySelectorAll( '.pollux-tabs a' );
325			pollux.tabs.views = document.querySelectorAll( '.pollux-config .form-table' );
326
327			[].forEach.call( pollux.tabs.tabs, function( tab, index ) {
328			var active = location.hash ? tab.getAttribute( 'href' ).slice(1) === location.hash.slice(2) : index === 0;
329			if( active ) {
330			pollux.tabs.setTab( tab );
331			}
332			tab.addEventListener( 'click', pollux.tabs.onClick );
333			tab.addEventListener( 'touchend', pollux.tabs.onClick );
334			});
335			};
336
337			/**
338			* @return void
339			*/
340			pollux.tabs.onClick = function( ev )
341			{
342			ev.preventDefault();
343			this.blur();
344			pollux.tabs.setTab( this );
345			location.hash = '!' + this.getAttribute( 'href' ).slice(1);
346			};
347
348			/**
349			* @return void
350			*/
351			pollux.tabs.setReferrer = function( index )
352			{
353			var referrerUrl = pollux.tabs.referrer.value.split('#')[0] + '#!' + pollux.tabs.views[index].id;
354			pollux.tabs.referrer.value = referrerUrl;
355			};
356
357			/**
358			* @return void
359			*/
360			pollux.tabs.setTab = function( el )
361			{
362			[].forEach.call( pollux.tabs.tabs, function( tab, index ) {
363			var action = pollux.classListAction( tab === el );
364			if( action === 'add' ) {
365			pollux.tabs.active.value = pollux.tabs.views[index].id;
366			pollux.tabs.setReferrer( index );
367			pollux.tabs.setView( index );
368			}
369			tab.classList[action]( 'nav-tab-active' );
370			});
371			};
372
373			/**
374			* @return void
375			*/
376			pollux.tabs.setView = function( idx )
377			{
378			[].forEach.call( pollux.tabs.views, function( view, index ) {
379			var action = pollux.classListAction( index !== idx );
380			view.classList[action]( 'ui-tabs-hide' );
381			});
382			};
383
384			jQuery(function() {
385			for( var key in pollux ) {
			0 ignored issues – show Complexity introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report A for in loop automatically includes the property of any prototype object, consider checking the key using `hasOwnProperty`. When iterating over the keys of an object, this includes not only the keys of the object, but also keys contained in the prototype of that object. It is generally a best practice to check for these keys specifically: var someObject; for (var key in someObject) { if ( ! someObject.hasOwnProperty(key)) { continue; // Skip keys from the prototype. } doSomethingWith(key); } Loading history...
386			if( !pollux[key].hasOwnProperty( 'init' ))continue;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-12 06:12 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
387			pollux[key].init();
388			}
389			});
390

pryley / pollux

Push — develop ( a578dd...775faa )

pollux.dependency.onClick A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like